- From: Adrian Hope-Bailie <notifications@github.com>
- Date: Mon, 07 Aug 2017 12:01:29 +0000 (UTC)
- To: w3c/payment-request <payment-request@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
- Message-ID: <w3c/payment-request/pull/574/review/54634291@github.com>
adrianhopebailie commented on this pull request. > @@ -841,9 +841,9 @@ </li> <li>Determine which <a>payment handlers</a> support <var>identifier</var>. For each resulting payment handler, if - payment method specific capabilities supplied by the payment - handler match those provided by <var>data</var>, the payment - handler matches. + <var>data</var> contains filters that exclude the payment The current wording is not just "hand-wavy" it's incorrect. The intent when this was designed was that a handler matches by default UNLESS something provided in the `data` part of the request excludes it. The current wording suggests that a payment handler ONLY matches if the appropriate `data` is provided. Example: If the handler supports `basic-card` and supported networks of `visa` and `mastercard` the current text suggests that the payment request MUST list `visa` or `mastercard` under `supportedNetworks` in the `data` of the request or it will not match. The intent is that a payment request with a method of `basic-card` and an empty `data` should match. i.e Empty implies, "no filter applied". We've used the terminology "filters" for requests and "capabilities" for handlers for some time so not sure I understand this, but whatever... > I can't accept a PR with the word "filter". -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/w3c/payment-request/pull/574#discussion_r131636558
Received on Monday, 7 August 2017 12:02:05 UTC