Re: [w3c/browser-payment-api] l10n: adds Localizable dict + TextDirection enum (closes #327) (#455)

domenic requested changes on this pull request.



> @@ -1108,7 +1108,7 @@
         <dfn>PaymentDetailsBase</dfn> dictionary
       </h2>
       <pre class="idl">
-        dictionary PaymentDetailsBase {
+        dictionary PaymentDetailsBase : Localizable {

I don't think it should go here if it only applies to PaymentDetailsUpdate. Instead you're going to have to just duplicate the two things (or use a partial dictionary PaymentDetailsUpdate).

If you put it here then PaymentDetailsInit gets it, and in particular that means passing `{ get dir() { throw new Error("boo"); }` to places that expect a PaymentDetailsInit must throw.

> +    </section>
+    <section data-dfn-for="TextDirection" data-link-for=
+    "TextDirection">
+      <h2>
+        <dfn>TextDirection</dfn> enum
+      </h2>
+      <pre class="idl">
+        enum TextDirection {
+          "auto",
+          "ltr",
+          "rtl"
+        };
+      </pre>
+      <p>
+        The text-direction values are the following, implying that the value of
+        the human-readable members is by default:

This sentence doesn't make sense to me.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/w3c/browser-payment-api/pull/455#pullrequestreview-34429749