- From: ianbjacobs <notifications@github.com>
- Date: Mon, 17 Apr 2017 16:23:30 -0700
- To: w3c/webpayments-payment-handler <webpayments-payment-handler@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
- Message-ID: <w3c/webpayments-payment-handler/pull/138/review/33113336@github.com>
ianbjacobs commented on this pull request.
> <section>
<h2>
<dfn>instruments</dfn> attribute
</h2>
<p>
This attribute allows manipulation of payment instruments
- associated with a payment handler. To be presented to the user as
- part of the payment request flow, payment handlers must have at
- least one registered payment Instrument, and that Instrument needs
- to match the payment methods and required capabilities specified by
- the payment request.
+ associated with a service worker (and therefor its payment
+ handler). To be invoked by the user as part of the payment request
+ flow, payment handlers must have at least one registered payment
+ instrument to present to the user. That instrument needs to match
+ the payment methods and required capabilities specified by the
+ payment request.
Notes:
* s/therefor/therefore
* "To be invoked by the user as part of the payment request flow"
I believe earlier you refer to them as candidate payment handlers. So would it make sense to say:
"To be a candidate payment handler, a handler must have at least one registered payment instrument..."
* s/specified by the payment request/of the <a>PaymentRequest</a>
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/w3c/webpayments-payment-handler/pull/138#pullrequestreview-33113336
Received on Monday, 17 April 2017 23:24:27 UTC