- From: ianbjacobs <notifications@github.com>
- Date: Mon, 17 Apr 2017 16:10:11 -0700
- To: w3c/webpayments-payment-handler <webpayments-payment-handler@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
- Message-ID: <w3c/webpayments-payment-handler/pull/138/review/33111658@github.com>
ianbjacobs commented on this pull request.
> @@ -362,13 +361,12 @@
"PaymentManager.instruments">instruments</a> and <a data-lt=
"PaymentManager.wallets">wallets</a>.
</li>
- <li>Payment apps make use of <a>service worker</a>s, starting with
- registration of their capabilities with the user agent. A service
- worker registration has zero or one <a>payment handler</a>. However, an
- origin may implement a payment app with more than one service worker
- registration.
+ <li>Payment apps make use of <a>service worker</a>s which must define a
+ <a>payment handler</a> to handle the <a>PaymentRequestEvent</a>s that
+ are raised by the user agent.
I have several questions about your proposed change:
* As we are still in the introduction, I would like to keep the fact that it is through registration that a user agent learns about (some) payment app capabilities: those related to payment handling.
* It is not clear to me that user agents "raise" these events. Rather, they result from the PR API invocation.
How about instead:
<li>Payment apps make use of <a>service worker</a>s to register their payment handling capabilities with the user agent. This is done through a <a>payment handler</a>, which listens to <a>PaymentRequestEvent</a>s raised through the Payment Request API.</li>
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/w3c/webpayments-payment-handler/pull/138#pullrequestreview-33111658
Received on Monday, 17 April 2017 23:11:09 UTC