Re: [w3c/browser-payment-api] Example update (#317)

marcoscaceres requested changes on this pull request.



>      <p>
       The <a>user agent</a> should never share information about the user to the web page
       (such as the shipping address) without user consent.
     </p>
   </section>
+  <section>
+    <h3>Incognito Mode</h3>
+    <ul>

Seems odd to have this as an `ul`. Maybe switch back to paragraph. Also, I think the TAG was trying to nail down what to call "incognito mode" (that's quite Chrome specific terminology, I think). 

>      <p>
       The <a>user agent</a> should never share information about the user to the web page
       (such as the shipping address) without user consent.
     </p>
   </section>
+  <section>
+    <h3>Incognito Mode</h3>
+    <ul>
+      <li>This API should remain available in a browser's "incognito mode".</li>
+      <li>Browsers that offer "persistent permission" features for sharing user payment information automatically with merchants should ignore those settings in icognito mode and require explicit user consent.</li>

Persistent permissions should link to the Permission spec. I think it defines what that is. 


> @@ -297,7 +297,11 @@
           <pre class="example highlight">
             [
               {
-                supportedMethods: ["visa","bitcoin"]
+                supportedMethods: ["basic-card"]
+           data: {

nit: whitespace. 

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/w3c/browser-payment-api/pull/317#pullrequestreview-9157178