Re: [w3c/browser-payment-api] Merged PaymentRequest params and tweaked to address some issues (#133)

>            <pre class="example highlight">
> -            ["visa", "bitcoin", "bobpay.com"]
> +            {
> +              "amount" : [{
> +                  "currency" : "USD",
> +                  "value" : "55.00"
> +              }],
> +              "supportedMethods" : [
> +                {
> +                  "identifers" : ["visa", "mastercard"],
> +                  "data" : {}
> +                },
> +                {
> +                  "identifers" : ["bobpay.com"],
> +                  "data" : {

> 'data' seems too generic. Perhaps... identifierData?

Happy to bikeshed this, it's a very minor detail. @msporny also has reservations about the specific member name. As this PR has some impactful changes it is hard to merge anything else while this is still pending. I recommend that if there are no objections to the PR we merge and then deal with these minor issues in new PRs.

> Also, do we imagine being able to support identifier-specific pricing in here?

Yes, I have an issue note to that effect but didn't want to try and do too much in one PR. This is already a necessarily wide ranging change so anything that could be left to another PR is still pending.

---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/w3c/browser-payment-api/pull/133/files/cf56b89b9fd4927e652f57db1b2d2c0d8a7d5aa5#r60031368