- From: Arun Ranganathan <arun@mozilla.com>
- Date: Tue, 16 Jul 2013 10:38:48 -0400
- To: Aymeric Vitte <vitteaymeric@gmail.com>
- Cc: "public-webcrypto@w3.org Group (public-webcrypto@w3.org)" <public-webcrypto@w3.org>, GALINDO Virginie <Virginie.GALINDO@gemalto.com>
On Jul 15, 2013, at 6:57 PM, Aymeric Vitte wrote:
> Hi Arun,
>
> Some small comments after a quick review (sorry limited time right now) :
>
> - is it on purpose that you are using "==" instead of "==="?
>
Not quite on purpose, so I've fixed this! "==" is simply a bad habit.
> - Code sancity and ... :
> .then(function(digest) {if (ok) {} else {get src}}, function(error) {get src})
> No?
Yes! Fixed.
> and get src should be https since you mention the origin is tls
>
> - Webmail :
> window.crypto.subtle.importKey("jwk", jwkKey,..) --> window.crypto.subtle.importKey("jwk", jwkKeyObject,...)
>
So this is still an active discussion on the listserv, IMHO, and has not stabilized, which is why I left both options open. Do we use the JSON.parse variant, or the stringified JSON notation variant? I'm not sure yet.
-- A*
Received on Tuesday, 16 July 2013 14:39:36 UTC