Re: [webauthn] Remove `RegistrationResponseJSON.id` and `AuthenticationResponseJSON.id` (#2119)

> Fair point. Though perhaps it's debatable which is worse under the principle of least surprise: `*ResponseJSON` _duplicating_ `id` as `rawId`, or `*ResponseJSON` _missing_ the `rawId` attribute from the `*Response` types they're supposed to be mirroring?

Definitely debatable. I think the _primary_ reason for the JSON-motivated definitions is to supply all the necessary data a server needs _and no redundant info. The latter for reasons of reducing areas where data disagree—I realize `authenticatorData`, `publicKey`, etc. are redundant, but they make the job easier on the server which `id` and raw`Id` do not. The _secondary_ goal is to ensure the JSON-motivated definitions align closely to the IDL definitions in data and name (e.g., `clientExtensionsResults` instead of `extensions` which I've seen more often). When there is a contradiction between the two, the primary goal should win; but as you said, this is debatable.

-- 
GitHub Notification of comment by zacknewman
Please view or discuss this issue at https://github.com/w3c/webauthn/issues/2119#issuecomment-2284642474 using your GitHub account


-- 
Sent via github-notify-ml as configured in https://github.com/w3c/github-notify-ml-config

Received on Monday, 12 August 2024 18:18:43 UTC