- From: Emil Lundberg via GitHub <sysbot+gh@w3.org>
- Date: Wed, 22 Nov 2023 11:37:35 +0000
- To: public-webauthn@w3.org
emlun has just submitted a new pull request for https://github.com/w3c/webauthn: == Fix incorrect (?) reference in Add Virtual Authenticator == [ยง11.3. Add Virtual Authenticator](https://w3c.github.io/webauthn/#sctn-automation-add-virtual-authenticator) currently reads: >[...] >3. For each enumerable [own property](https://tc39.github.io/ecma262/#sec-own-property) in _parameters_: > > 1. Let _key_ be the name of the property. > 2. Let _value_ be the result of [getting a property](https://w3c.github.io/webdriver/#dfn-getting-properties) named _key_ from _parameters_. > 3. If there is no matching `key` for _key_ in _parameters_, return a [WebDriver error](https://w3c.github.io/webdriver/#dfn-error) with [WebDriver error code](https://w3c.github.io/webdriver/#dfn-error-code) [invalid argument](https://w3c.github.io/webdriver/#dfn-invalid-argument). > 4. If _value_ is not one of the `valid values` for that _key_, return a [WebDriver error](https://w3c.github.io/webdriver/#dfn-error) with [WebDriver error code](https://w3c.github.io/webdriver/#dfn-error-code) [invalid argument](https://w3c.github.io/webdriver/#dfn-invalid-argument). > 5. [Set a property](https://w3c.github.io/webdriver/#dfn-set-a-property) _key_ to _value_ on _authenticator_. >[...] The third step seems like it was intended to instead refer to [Authenticator Configuration](https://w3c.github.io/webauthn/#authenticator-configuration) as the set of valid keys: > 3. If there is no matching `key` for _key_ in [Authenticator Configuration](https://w3c.github.io/webauthn/#authenticator-configuration), return a [WebDriver error](https://w3c.github.io/webdriver/#dfn-error) with [WebDriver error code](https://w3c.github.io/webdriver/#dfn-error-code) [invalid argument](https://w3c.github.io/webdriver/#dfn-invalid-argument). The subsequent step 5 checks that all properties of [Authenticator Configuration](https://w3c.github.io/webauthn/#authenticator-configuration) are defined in _parameters_, so it seems it would make sense that step 3.3 would perform the opposite check, which would make the combination of both a set equality check rather than just a subset check. @nsatragno Is the above assessment accurate? See https://github.com/w3c/webauthn/pull/2001 -- Sent via github-notify-ml as configured in https://github.com/w3c/github-notify-ml-config
Received on Wednesday, 22 November 2023 11:37:36 UTC