- From: Emil Lundberg <noreply@github.com>
- Date: Thu, 22 Sep 2022 10:22:04 -0700
- To: public-webauthn@w3.org
Branch: refs/heads/issue-1752-incorrect-options-variable-option-2 Home: https://github.com/w3c/webauthn Commit: 70b6f644cab84c39d3947e770c45e6390c7622f7 https://github.com/w3c/webauthn/commit/70b6f644cab84c39d3947e770c45e6390c7622f7 Author: Emil Lundberg <emil@yubico.com> Date: 2022-09-22 (Thu, 22 Sep 2022) Changed paths: M index.bs Log Message: ----------- Fix incorrect use of options variables in create() and get() _§5.1.3. Create a New Credential_ and _§5.1.4. Use an Existing Credential to Make an Assertion_ both declare their **options** parameter as the `Credential[Creation|Request]Options` object inherited from CredMan: >**options** >This argument is a `CredentialCreationOptions` object whose >_options_.`publicKey` member contains a `PublicKeyCredentialCreationOptions` >object [...] Both also re-assign the _options_ variable: >Let _options_ be the value of _options_.`publicKey`. But both then also reference _options_.`signal`, which is a member of `Credential[Creation|Request]Options` but not `PublicKeyCredential[Creation|Request]Options`: >If _options_.`signal` is present and aborted, throw the _options_.`signal`’s abort reason. _§5.1.4. Use an Existing Credential to Make an Assertion_ also incorrectly references _options_.`mediation` in a similar way. This fixes the issue by introducing new variables for _signal_ and _mediation_, so that _options_ can continue to reference the `publicKey` member of the original _options_ value.
Received on Thursday, 22 September 2022 17:22:17 UTC