- From: Emil Lundberg via GitHub <sysbot+gh@w3.org>
- Date: Wed, 05 Oct 2022 19:13:48 +0000
- To: public-webauthn@w3.org
The following commits were just pushed by emlun to https://github.com/w3c/webauthn: * Fix incorrect use of options variables in create() and get() _§5.1.3. Create a New Credential_ and _§5.1.4. Use an Existing Credential to Make an Assertion_ both declare their **options** parameter as the `Credential[Creation|Request]Options` object inherited from CredMan: >**options** >This argument is a `CredentialCreationOptions` object whose >_options_.`publicKey` member contains a `PublicKeyCredentialCreationOptions` >object [...] Both also re-assign the _options_ variable: >Let _options_ be the value of _options_.`publicKey`. But both then also reference _options_.`signal`, which is a member of `Credential[Creation|Request]Options` but not `PublicKeyCredential[Creation|Request]Options`: >If _options_.`signal` is present and aborted, throw the _options_.`signal`’s abort reason. _§5.1.4. Use an Existing Credential to Make an Assertion_ also incorrectly references _options_.`mediation` in a similar way. This fixes the issue by introducing a new variable _pkOptions_ instead of re-assigning the existing variable _options_, so that _options_ can keep its original value. by Emil Lundberg https://github.com/w3c/webauthn/commit/3a543c49828b86ecd1266a42534d6a25e32cc7e2 * Merge pull request #1805 from w3c/issue-1752-incorrect-options-variable Fix incorrect use of options variable: rename to pkOptions by Emil Lundberg https://github.com/w3c/webauthn/commit/e0d10dd63207720e1fb42f96515ab9fe2b442248 -- Sent via github-notify-ml as configured in https://github.com/w3c/github-notify-ml-config
Received on Wednesday, 5 October 2022 19:13:50 UTC