- From: Emil Lundberg via GitHub <sysbot+gh@w3.org>
- Date: Wed, 05 Oct 2022 09:32:21 +0000
- To: public-webauthn@w3.org
emlun has just closed emlun's pull request 1806 for https://github.com/w3c/webauthn:
== Fix incorrect use of options variable: extract signal and mediation attributes first ==
Fixes #1752. This is a mutually exclusive alternative to PR #1805. I couldn't decide which approach is better, but I'm slightly favouring #1805 over this one.
This fixes the issue by introducing new variables for _signal_ and _mediation_, so that _options_ can continue to reference the `publicKey` member of the original _options_ value.
<!--
This comment and the below content is programmatically generated.
You may add a comma-separated list of anchors you'd like a
direct link to below (e.g. #idl-serializers, #idl-sequence):
Don't remove this comment or modify anything below this line.
If you don't want a preview generated for this pull request,
just replace the whole of this comment's content by "no preview"
and remove what's below.
-->
***
<a href="https://pr-preview.s3.amazonaws.com/w3c/webauthn/pull/1806.html" title="Last updated on Sep 22, 2022, 5:26 PM UTC (70b6f64)">Preview</a> | <a href="https://pr-preview.s3.amazonaws.com/w3c/webauthn/1806/0bfc0d0...70b6f64.html" title="Last updated on Sep 22, 2022, 5:26 PM UTC (70b6f64)">Diff</a>
See https://github.com/w3c/webauthn/pull/1806
--
Sent via github-notify-ml as configured in https://github.com/w3c/github-notify-ml-config
Received on Wednesday, 5 October 2022 09:32:23 UTC