W3C home > Mailing lists > Public > public-webauthn@w3.org > May 2020

[webauthn] Merged Pull Request: Substitute enum types in dictionaries with DOMStrings

From: =JeffH via GitHub <sysbot+gh@w3.org>
Date: Wed, 27 May 2020 19:10:44 +0000
To: public-webauthn@w3.org
Message-ID: <pull_request.closed-393269332-1590606643-sysbot+gh@w3.org>
equalsJeffH has just merged jcjones's pull request 1392 for https://github.com/w3c/webauthn:

== Substitute enum types in dictionaries with DOMStrings ==
This fixes issue #1376, auditing all enums passed into WebAuthn to ensure that WebAuthn can be extended without causing WebIDL failures for lagging implementations.

I believe I caught them all. I prefixed all the targets with `>>` in the list below:

dictionary PublicKeyCredentialCreationOptions {
    required PublicKeyCredentialRpEntity         rp;
    required PublicKeyCredentialUserEntity       user;

    required BufferSource                             challenge;
    required sequence<PublicKeyCredentialParameters>  pubKeyCredParams;

    unsigned long                                timeout;
    sequence<PublicKeyCredentialDescriptor>      excludeCredentials = [];
    AuthenticatorSelectionCriteria               authenticatorSelection;
>>    AttestationConveyancePreference              attestation = "none";
    AuthenticationExtensionsClientInputs         extensions;

dictionary PublicKeyCredentialRequestOptions {
    required BufferSource                challenge;
    unsigned long                        timeout;
    USVString                            rpId;
    sequence<PublicKeyCredentialDescriptor> allowCredentials = [];
>>    UserVerificationRequirement          userVerification = "preferred";
    AuthenticationExtensionsClientInputs extensions;

dictionary AuthenticatorSelectionCriteria {
>>    AuthenticatorAttachment      authenticatorAttachment;
    boolean                      requireResidentKey = false;
>>    UserVerificationRequirement  userVerification = "preferred";

dictionary PublicKeyCredentialDescriptor {
>>    required PublicKeyCredentialType      type;
    required BufferSource                 id;
    sequence<DOMString>                   transports;

dictionary TokenBinding {
>>    required TokenBindingStatus status;
    DOMString id;

dictionary PublicKeyCredentialParameters {
>>    required PublicKeyCredentialType      type;
    required COSEAlgorithmIdentifier      alg;

    This comment and the below content is programatically generated.
    You may add a comma-separated list of anchors you'd like a
    direct link to below (e.g. #idl-serializers, #idl-sequence):

    Don't remove this comment or modify anything below this line.
    If you don't want a preview generated for this pull request,
    just replace the whole of this comment's content by "no preview"
    and remove what's below.
<a href="https://pr-preview.s3.amazonaws.com/jcjones/webauthn/pull/1392.html" title="Last updated on May 15, 2020, 6:04 PM UTC (42dbe07)">Preview</a> | <a href="https://pr-preview.s3.amazonaws.com/w3c/webauthn/1392/d530669...jcjones:42dbe07.html" title="Last updated on May 15, 2020, 6:04 PM UTC (42dbe07)">Diff</a>

See https://github.com/w3c/webauthn/pull/1392
Received on Wednesday, 27 May 2020 19:10:46 UTC

This archive was generated by hypermail 2.4.0 : Tuesday, 5 July 2022 07:26:40 UTC