W3C home > Mailing lists > Public > public-webauthn@w3.org > November 2019

Re: [webauthn] reverting and restoring automation section et al... (#1340)

From: =JeffH via GitHub <sysbot+gh@w3.org>
Date: Thu, 07 Nov 2019 01:04:09 +0000
To: public-webauthn@w3.org
Message-ID: <issue_comment.created-550572130-1573088648-sysbot+gh@w3.org>
thanks @emlun for [the detailed analysis/explanation](https://github.com/w3c/webauthn/pull/1340#issuecomment-550462834)! (I had not yet seen it during the webauthn call earlier today)!  

So, in master branch, I've diffed the spec rendered at the most recent commit 8927216 from the rendered spec at commit 976391d, i.e.:  [8927216..976391d], and gone through the diff and matched up new/revised text with the commits listed by `git hist` in that interval, and it looks like everthing is there in the present most-recent state in master branch, in `index.bs` -- yay!

HOWEVER, it seems that we've overlooked restoring the revised .svg file that @agl commited & merged-to-master for [figure 6](https://w3c.github.io/webauthn/#fig-stringTruncation)  -- the file being: `images/string-truncation.svg`.  see the potentially-relevant commit `428bf82 2019-10-29 | Truncate strings for authenticators where needed. (#1316) [Adam Langley]`

@agl likely has this file on his machine and perhaps it's easiest to just open a new PR to update said file (rather than mess around trying to restore it using git-magic) ?

ANYWAY, we shouldn't roll an updated working draft until we've fixed this, please.

-- 
GitHub Notification of comment by equalsJeffH
Please view or discuss this issue at https://github.com/w3c/webauthn/pull/1340#issuecomment-550572130 using your GitHub account
Received on Thursday, 7 November 2019 01:04:11 UTC

This archive was generated by hypermail 2.4.0 : Friday, 17 January 2020 18:59:08 UTC