W3C home > Mailing lists > Public > public-webauthn@w3.org > October 2018

[webauthn] Pull Request: Add the word "OPTIONAL" to `userVerification` field to match surrounding style.

From: Lucas Garron via GitHub <sysbot+gh@w3.org>
Date: Fri, 05 Oct 2018 05:23:48 +0000
To: public-webauthn@w3.org
Message-ID: <pull_request.opened-220588901-1538717027-sysbot+gh@w3.org>
lgarron has just submitted a new pull request for https://github.com/w3c/webauthn:

== Add the word "OPTIONAL" to `userVerification` field to match surrounding style. ==
Previously, `userVerification` was the only optional field of `PublicKeyCredentialRequestOptions` that didn't include the word "OPTIONAL", which can suggest at first glance that this field is not optional like the other optional ones. Adding the word is simple, and should avoid potential confusion.

https://github.com/DefinitelyTyped/DefinitelyTyped/pull/29463 is a case where types based on this doc had this optional field as required (along with `rpId`). I don't know if that was a mistake or simply outdated, but the inconsistency in the word "OPTIONAL" made this a bit confusing to check at first.

See https://github.com/w3c/webauthn/pull/1094
Received on Friday, 5 October 2018 05:23:49 UTC

This archive was generated by hypermail 2.4.0 : Tuesday, 5 July 2022 07:26:35 UTC