W3C home > Mailing lists > Public > public-webauthn@w3.org > June 2018

Re: [webauthn] PR #900 post-merge review changes

From: Emil Lundberg via GitHub <sysbot+gh@w3.org>
Date: Thu, 07 Jun 2018 15:46:39 +0000
To: public-webauthn@w3.org
Message-ID: <issue_comment.created-395469787-1528386398-sysbot+gh@w3.org>
Thanks @equalsJeffH for the review! I also added the change rephrasing the |authenticators| definition steps; that commit was not included in your https://github.com/w3c/webauthn/pull/940#pullrequestreview-126831731 but it shows up earlier in the event log because I wrote the commit ahead of time but didn't push it.

Since these changes would have belonged in #900, I'll regard this as ready to merge once @equalsJeffH signs off on commit 8b6b7e1ded0f64806da8a739f4879bc5edfc7c6f . I'll go ahead and perform the merge if nobody objects before 2018-06-11T08:00Z (and if nobody else does it before then :) ).

-- 
GitHub Notification of comment by emlun
Please view or discuss this issue at https://github.com/w3c/webauthn/pull/940#issuecomment-395469787 using your GitHub account
Received on Thursday, 7 June 2018 15:46:46 UTC

This archive was generated by hypermail 2.4.0 : Tuesday, 5 July 2022 07:26:33 UTC