- From: Adam Langley via GitHub <sysbot+gh@w3.org>
- Date: Thu, 02 Aug 2018 16:40:44 +0000
- To: public-webauthn@w3.org
In Chrome [CredentialCreationOptions](https://cs.chromium.org/chromium/src/third_party/blink/renderer/modules/credentialmanager/credential_creation_options.idl?sq=package:chromium&dr=C&g=0) has three optional members and the code [checks](https://cs.chromium.org/chromium/src/third_party/blink/renderer/modules/credentialmanager/credentials_container.cc?rcl=dd904c24e3ad753c029e6e12ce6248e2f5a1397e&l=551) that exactly one of them is present and dispatches based on which it is. When we create a [Credential object](https://cs.chromium.org/chromium/src/third_party/blink/renderer/modules/credentialmanager/credential.idl?sq=package:chromium&dr=C&g=0) the subclass sets the `type` member and the public-key credential sets it to [`public-key`](https://cs.chromium.org/chromium/src/third_party/blink/renderer/modules/credentialmanager/public_key_credential.cc?rcl=cf64e143fc871fae4bc0522241294d34b832c33f&l=35), as expected. I don't understand why these two strings need to be same and thus why a change is being suggested here. -- GitHub Notification of comment by agl Please view or discuss this issue at https://github.com/w3c/webauthn/issues/1004#issuecomment-409991144 using your GitHub account
Received on Thursday, 2 August 2018 16:41:20 UTC