PR #586 review submitted

please see: 
<https://github.com/w3c/webauthn/pull/586#pullrequestreview-65432034>

This seems basically OK, tho there are a few detail-level things we need 
to fixup.

Also, here's the applicable WebIDL section:
https://heycam.github.io/webidl/#idl-buffer-source-types

Note the admonition in orange that begins: "Extreme care must be taken 
when writing specification text that gets a reference to the bytes held 
by a buffer source, as the underyling data can easily be changed by the 
script author or other APIs at unpredictable times. ..."

I am betting that to be really correct, we need to make copies of the 
buffersource types that we manipulate in the algorithms, using the [get 
a copy of the bytes held by the buffer 
source](https://heycam.github.io/webidl/#dfn-get-buffer-source-copy) 
language in the paragraph above the orange admonition.  but this 
detail-level issue existed before this PR was created.

Received on Wednesday, 27 September 2017 06:43:50 UTC