W3C home > Mailing lists > Public > public-webauthn@w3.org > October 2017

Re: [webauthn] Define Public Key Credential Source and Credential ID.

From: =JeffH via GitHub <sysbot+gh@w3.org>
Date: Tue, 24 Oct 2017 21:22:37 +0000
To: public-webauthn@w3.org
Message-ID: <issue_comment.created-339135880-1508880155-sysbot+gh@w3.org>
@jyasskin: if I understand correctly, [you are suggesting](https://github.com/w3c/webauthn/pull/620#issuecomment-338787049) these _**further**_ changes to add to this PR..
> * Credential ID -> Credential Source ID
> * assertion -> credential globally
> * PublicKeyCredentialDescriptor -> PublicKeyCredentialSourceDescriptor

..yes?

Those above suggestions would be breaking changes.  It might be possible to convince folks to do "Credential ID -> Credential Source ID" -- it would only (breaking) change [`credentialidlength`](https://w3c.github.io/webauthn/#credentialidlength) and [`credentialid`](https://w3c.github.io/webauthn/#credentialid) in section [#sec-attested-credential-data](https://w3c.github.io/webauthn/#sec-attested-credential-data). 

Otherwise, IIUC, I do not support the other two changes at this time, and am not sure they would buy us that much in general. Those latter two changes, especially renaming "assertion", would be quite invasive, both editorially and technically (ie, in renaming API components, section names, terminology, etc, senses). 

In any case, I have detail-level comments that I'm working on entering in that I generally support _**this**_ PR's present substance. 


-- 
GitHub Notification of comment by equalsJeffH
Please view or discuss this issue at https://github.com/w3c/webauthn/pull/620#issuecomment-339135880 using your GitHub account
Received on Tuesday, 24 October 2017 21:22:43 UTC

This archive was generated by hypermail 2.4.0 : Tuesday, 5 July 2022 07:26:29 UTC