W3C home > Mailing lists > Public > public-webauthn@w3.org > October 2017

[w3c/webauthn] d0a010: Fix #618 - Make PublicKeyCredential.isPlatformAuth...

From: GitHub <noreply@github.com>
Date: Wed, 11 Oct 2017 13:01:28 -0700
To: public-webauthn@w3.org
Message-ID: <59de78984b1ab_153f3fd1d3005c284758d@hookshot-fe6-cp1-prd.iad.github.net.mail>
  Branch: refs/heads/master
  Home:   https://github.com/w3c/webauthn
  Commit: d0a010cd6a23b96044ae0708dd8bb33bff66dc78
      https://github.com/w3c/webauthn/commit/d0a010cd6a23b96044ae0708dd8bb33bff66dc78
  Author: J.C. Jones <jc@mozilla.com>
  Date:   2017-10-09 (Mon, 09 Oct 2017)

  Changed paths:
    M index.bs

  Log Message:
  -----------
  Fix #618 - Make PublicKeyCredential.isPlatformAuthenticatorAvailable static

The example in the spec shows static usage of isPlatformAuthenticatorAvailable,
but isPlatformAuthenticatorAvailable is defined [Unscopable], which is a regular
operation which is defined as being not static.

I think the static method of using this is what we want, actually. Declaring
this as a non-static method on PublicKeyCredential means users need to obtain a
concrete PublicKeyCredential object on which to call
isPlatformAuthenticatorAvailable(). This leads to a situation where you have to
first complete a call to navigator.credentials.create() in order to call
isPlatformAuthenticatorAvailable().


  Commit: b0a205bc0010df59ab4657f83429b33b932cf552
      https://github.com/w3c/webauthn/commit/b0a205bc0010df59ab4657f83429b33b932cf552
  Author: J.C. Jones <james.jc.jones@gmail.com>
  Date:   2017-10-11 (Wed, 11 Oct 2017)

  Changed paths:
    M index.bs

  Log Message:
  -----------
  Merge pull request #619 from jcjones/618-isPlatformAuthenticatorAvailable

Fix #618 - Make PublicKeyCredential.isPlatformAuthenticatorAvailable static


Compare: https://github.com/w3c/webauthn/compare/d89c5031770f...b0a205bc0010
Received on Wednesday, 11 October 2017 21:07:14 UTC

This archive was generated by hypermail 2.4.0 : Tuesday, 5 July 2022 07:26:28 UTC