Re: [webauthn] Creation of ScopedCredentialInfo in makeCredential should probably be more explicit

@bzbarsky wrote:
> ScopedCredentialInfo doesn't have a useful place to put a 
clientDataJSON. Presumably that should go into the clientData member 
of the attestation member of the ScopedCredentialInfo? That needs to 
be made clear.

fixed by PR #321 (merged)

> In general, I think it would be good to define the interface between
 this code and 
more clearly in terms of which part of the return set of things go 
where on the object that gets created. For example, 
says that it needs to return
> >    The fields of the attestation structure WebAuthnAttestation, 
including information about the attestation format used.
> but it has no way to return the clientDataJSON, because it doesn't 
have it...

fixed by PR #321 (merged)

> Also, is authenticatorMakeCredential expected to create the 
ArrayBuffer for the new ScopedCredentials's id member? Or is that the 
job of makeCredential? Presumably the latter, right? 

Yes, as of merged PR #347.

> Which global is that ArrayBuffer created in? Presumably this 
creation step needs to happen off a task queued back to some task 
queue, since it's going to need to create ES objects, so can't happen 
on random background threads. Which task queue? That matters in terms 
of event ordering with other things. Which globals are used for the 
various other objects involved in this ScopedCredentialInfo?

This is not yet addressed AIUI. I'll grep for 'global' and 
'task queue' examples and try to formulate an answer, tho any 
additional hints/pointers will be appreciated. :)

GitHub Notification of comment by equalsJeffH
Please view or discuss this issue at 
using your GitHub account

Received on Thursday, 2 March 2017 00:08:32 UTC