Re: [webauthn] PublicKeyCredentialRequestOptions and MakeCredentialOptions could both inherit from a dictionary which has their shared members

We've done some renaming since this issue was submitted. Presently:
* AssertionOptions -> PublicKeyCredentialRequestOptions
* ScopedCredentialOptions ->  MakeCredentialOptions

..so I will update the title of this issue. 

Also, the alignment of WebAuthn with [CredMan](https://w3c.github.io/webappsec-credential-management/) _did not_ address this issue as I'd been (incorrectly) suspecting. 

PublicKeyCredentialRequestOptions and MakeCredentialOptions do inherit from different dictionaries defined in CredMan. 

Also, PublicKeyCredentialRequestOptions and MakeCredentialOptions continue to share three common members:
```
required BufferSource                challenge;

unsigned long                        timeout;

AuthenticationExtensions             extensions;
```

So, if this is indeed something that we ought to address, then we should define a "PublicKeyCredentialOptions"dictionary, say, whose members are the above three items, and then have PublicKeyCredentialRequestOptions and MakeCredentialOptions inherit from it. 

Also, rpId is common between PublicKeyCredentialRequestOptions and MakeCredentialOptions, but at different depths within the dictionaries.  Is this also something to deal with or is it fine as it is?

See also #488





-- 
GitHub Notification of comment by equalsJeffH
Please view or discuss this issue at https://github.com/w3c/webauthn/issues/278#issuecomment-306321898 using your GitHub account

Received on Monday, 5 June 2017 21:55:56 UTC