Re: [webauthn] Adding CDDL to txAuthSimple


Thanks for the review.  I have tried to address your comments, and I still am not sure we are there yet.

a) extidArg and extidRetVal conventions are fine, in my opinion.  They should be specified in, but as far as I can tell they are not.

b) I didn't leverage your suggested CDDL notation exactly, because I thought it would be clearer to represent the values as CBOR maps.

c) Although it was not the original intent of this PR, should we be more explicit about what is expected in the client extension input?  "A single JSON string prompt" seems like it can be interpreted in multiple ways.  If you have a suggestion, I can incorporate it into the PR and take care of that as well.

GitHub Notification of comment by gmandyam
Please view or discuss this issue at using your GitHub account

Received on Wednesday, 20 December 2017 16:35:17 UTC