- From: =JeffH via GitHub <sysbot+gh@w3.org>
- Date: Fri, 01 Dec 2017 17:21:46 +0000
- To: public-webauthn@w3.org
@AngeloKai sez that my pushing directly to https://github.com/AngeloKai/webauthn:master at this time is inconvenient, so here's a hist of the latest commits in that branch including mine in my local clone:
```
> githist
* 26af148 2017-12-01 | edit [[DiscoverFromExternalSource]] dfn & markup (HEAD -> master) [JeffH]
* 6ac3d01 2017-12-01 | remove unnecessary commits (origin/master, origin/HEAD) [Angelo Liao]
* 2c936a6 2017-12-01 | resolve linking error: idl ref not found for [[DiscoverFromExternalSource]](origin, options, sameOriginWithAncestors) [Angelo Liao]
* e04880f 2017-12-01 | resolve linking error for AttestationNotPrivateError [Angelo Liao]
* 234a61f 2017-12-01 | Merge branch 'master' of https://github.com/w3c/webauthn [Angelo Liao]
```
and here's the diff of what I propose we change, between the two most-recent commits shown above:
```
> git diff 6ac3d01..26af148
diff --git a/index.bs b/index.bs
index 2efe8d1..29792f3 100644
--- a/index.bs
+++ b/index.bs
@@ -982,12 +982,11 @@ for="PublicKeyCredential" method>\[[CollectFromCredentialStore]](origin, options
{{Credential/[[CollectFromCredentialStore]]()|Credential.[[CollectFromCredentialStore]]()}}, of returning an empty set.
-<h5 id="discover-from-external-source" algorithm>PublicKeyCredential's `[[DiscoverFromExternalSource]](origin, options, sameOriginWithAncestors)` method</h5>
+<h5 id="discover-from-external-source" algorithm>PublicKeyCredential's <code><dfn for="PublicKeyCredential" method>\[[DiscoverFromExternalSource]](origin, options, sameOriginWithAncestors)</dfn></code> method</h5>
<div link-for-hint="PublicKeyCredential/[[DiscoverFromExternalSource]](origin, options, sameOriginWithAncestors)">
-{{PublicKeyCredential}}'s [=interface object=]'s implementation of the
-<dfn for="PublicKeyCredential" method>\[[DiscoverFromExternalSource]](origin, options, sameOriginWithAncestors)</dfn> [=internal method=] accepts three arguments:
+This [=internal method=] accepts three arguments:
<dl dfn-type="argument" dfn-for="PublicKeyCredential/[[DiscoverFromExternalSource]](origin, options, sameOriginWithAncestors)">
```
--
GitHub Notification of comment by equalsJeffH
Please view or discuss this issue at https://github.com/w3c/webauthn/pull/703#issuecomment-348555000 using your GitHub account
Received on Friday, 1 December 2017 17:21:49 UTC