review of PR #384 submitted

https://github.com/w3c/webauthn/pull/384#pullrequestreview-31386777

Overall this PR looks good, thanks for all your work on it @mikewest and 
@battre!

though, there's some rough edges to polish -- we might as well catch 
them now.

In addition to the individual comments below, here's some further ones 
that I was unable to directly attach to lines because they were not 
directly in the diff'd sections. line#s are relative to the righthand 
side of the side-by-side diff as of submitting this:

     line 236:
     s/conveyed in attestation objects./conveyed in attestation objects, 
see [[#generating-an-attestation-object]].

     line 1026:
     s/The client data represents the contextual bindings of both the 
[RP] and the client platform./The client data represents the contextual 
bindings of both the [RP] and the client platform collected during an 
invocation of either the {{create()}} or {{CredentialsContainer/get()}} 
methods./

also, overall, please consistently mark-up [=internal slot=] (this is an 
issue in credman also), and change all occurrences of just "slot" to 
"[=internal slot=] ".

thanks,

=JeffH

Received on Friday, 7 April 2017 21:21:55 UTC