W3C home > Mailing lists > Public > public-webauthn@w3.org > December 2016

Re: [webauthn] Specify encoding of rpid to bytes before hashing.

From: =JeffH via GitHub <sysbot+gh@w3.org>
Date: Wed, 14 Dec 2016 17:45:17 +0000
To: public-webauthn@w3.org
Message-ID: <issue_comment.created-267102622-1481737515-sysbot+gh@w3.org>
kpaulh -- thx for submitting this -- some thoughts/notes on this PR:

1.  the kpaulh github account (Kimberly Paulhamus?) is perhaps not 
anointed as a "member" of the WebAuthn WG ?  this might be causing the
 issue with the IPR check.

2.  the actual substantive changes in this PR are in lines 403 and 
499.  All the other changes appear to be elimination of line-end blank
 chars. 

3.  the commit message (incorrectly) says it closes issue #244 rather 
than #258..

4.  ..also, while the content of the changes to lines 403 and 499 seem
 nominally correct given how the algorithm steps are presently 
written, they will need to be re-written when we address various of 
the issues submitted by @bzbarsky.  as a part of that, we will likely 
invoke https://encoding.spec.whatwg.org/#utf-8-encode as suggested by 
@annevk 
https://github.com/w3c/webauthn/issues/258#issuecomment-258775438 -- 
so perhaps we shouldn't close #258 with this PR as it is presently 
written.

-- 
GitHub Notification of comment by equalsJeffH
Please view or discuss this issue at 
https://github.com/w3c/webauthn/pull/307#issuecomment-267102622 using 
your GitHub account
Received on Wednesday, 14 December 2016 17:45:23 UTC

This archive was generated by hypermail 2.4.0 : Tuesday, 5 July 2022 07:26:24 UTC