W3C home > Mailing lists > Public > public-webapps@w3.org > October to December 2015

RE: Can we land heycam's WebIDL tests as-is and address review comments following?

From: Zhang, Zhiqiang <zhiqiang.zhang@intel.com>
Date: Tue, 22 Dec 2015 01:35:15 +0000
To: Travis Leithead <travis.leithead@microsoft.com>, Simon Pieters <simonp@opera.com>, public-webapps <public-webapps@w3.org>, Yves Lafon <ylafon@w3.org>
Message-ID: <0EA8FB2070816C499E0A50AC1B0B5C163ACB8351@SHSMSX101.ccr.corp.intel.com>
Travis,

Great. Glad to hear that you are working on the tests.

Perhaps you can try Simon' method to make your update in a new branch in w3c/web-platform-tests, so that others can make updates together.

Thanks,
Zhiqiang

From: Travis Leithead [mailto:travis.leithead@microsoft.com]
Sent: Monday, December 21, 2015 11:44 PM
To: Simon Pieters <simonp@opera.com>; public-webapps <public-webapps@w3.org>; Zhang, Zhiqiang <zhiqiang.zhang@intel.com>; Yves Lafon <ylafon@w3.org>
Subject: RE: Can we land heycam's WebIDL tests as-is and address review comments following?


Yves and I have been reviewing these tests and revising them according to recent WebIDL changes and we think they may be ready to be integrated. The updates are in a PR on heycams page. Let's not integrate heycam's original PR until our update is done first please...







From: Simon Pieters<mailto:simonp@opera.com>
Sent: Monday, December 21, 2015 1:13 AM
To: public-webapps<mailto:public-webapps@w3.org>; Zhang, Zhiqiang<mailto:zhiqiang.zhang@intel.com>
Subject: Re: Can we land heycam's WebIDL tests as-is and address review comments following?


On Mon, 21 Dec 2015 07:34:12 +0100, Zhang, Zhiqiang
<zhiqiang.zhang@intel.com<mailto:zhiqiang.zhang@intel.com>> wrote:

> Hi,
>
> 2+ years ago, heycam submitted WebIDL tests at
>
> https://github.com/w3c/web-platform-tests/pull/271
>
> These tests have been reviewed by several guys but get no update ever
> since.
>
> I wonder if we could land the tests as-is and address the review
> comments in further pull requests? Then we can make a test suite to
> advance the specification and for people to understand the specification.
>
> Thoughts?
>
> Thanks,
> Zhiqiang

Personally I don't object to that plan, but an alternative is to create a
new branch in w3c/web-platform-tests with these changes, and anyone with
push access to w3c/web-platform-tests can make changes to that branch, and
then we can merge to master when it's ready.

     git fetch origin refs/pull/271/head:refs/remotes/origin/pr/271 --force
     git checkout -b webidl-tests origin/pr/271
     git push -u origin webidl-tests

--
Simon Pieters
Opera Software
Received on Tuesday, 22 December 2015 01:35:57 UTC

This archive was generated by hypermail 2.4.0 : Friday, 17 January 2020 18:14:58 UTC