W3C home > Mailing lists > Public > public-webapps@w3.org > October to December 2015

Re: Tests for new shadow DOM API

From: 河内 隆仁 <kochi@google.com>
Date: Fri, 2 Oct 2015 17:59:19 +0900
Message-ID: <CADP2=hr6aXN7g-09Nxbf6D+djYcrDkyDtk+Rk-3oBdPy6nhoeg@mail.gmail.com>
To: Ms2ger <ms2ger@gmail.com>
Cc: Ryosuke Niwa <rniwa@apple.com>, public-webapps <public-webapps@w3.org>
Hi,

Thanks Ryosuke for starting contributing tests to shadow-dom/ and moving
the old ones under untriaged/.

I would like to continue triaging old tests in untriaged/ directory.
The general rule of thumb (for me) for working on them are:

- Remove tests that test out-of-date features (e.g. attributes that is
removed from spec)
- If the test is doing something valid, carefully examine what is tested
and whether it is not
  duplicate of other tests (outside of untriaged/*). If it is a duplicate,
remove it.
- If the test passes above 2 bullets, then rewrite so that the test runs in
more sane way and
  submit for review, and remove the original once the new test lands.

And I'm happy to review any new or triaged test, please add @TakayoshiKochi
in your pull request.

Thank you!

On Fri, Sep 4, 2015 at 5:13 PM, Ms2ger <ms2ger@gmail.com> wrote:

> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> Hi Ryosuke,
>
> On 09/03/2015 10:06 PM, Ryosuke Niwa wrote:
> > Hi all,
> >
> > Where should we put tests for new shadow DOM API?  It looks like
> > the tests in
> > https://github.com/w3c/web-platform-tests/tree/master/shadow-dom/shado
> w-trees
> >
> >
> <https://github.com/w3c/web-platform-tests/tree/master/shadow-dom/shadow
> - -trees>
> > are mostly obsolete and I'm not certain how many of them could be
> > adopted for the new API.
> >
> > Would it make sense to rename this old one to
> > "deprecated-shadow-don" and then create a new top-level directory
> > "shadow-dom"?  We can then migrate or write new tests there.
> >
>
> If you believe a significant fraction of the existing tests is out of
> date with the specification, I'd suggest moving them all into
> `shadow-dom/untriaged` and adding a `README` file there to explain the
> situation.
>
> HTH
> Ms2ger
> -----BEGIN PGP SIGNATURE-----
>
> iQEcBAEBAgAGBQJV6VK2AAoJEOXgvIL+s8n2asAIAJEXWz8vyAGqPI6BFNNYQYXb
> 4i/knAt1/GEeiUOzjzbwJG38NRtGr9cZO0MCYW8S13gzzqKbtdCWwF0FbBvzvMR1
> OHqkdR7tLo/aLV00GQzrLSgNDnqQ2M1+P/lq5QUU53DsbpTM2Ih0P1pjDsvaLs75
> TZFggKN8UKhvjQrKuL1wjtCSKrdkemXKbdl2FfWgXj1hsUklNwKSmTd8Hr+g6FaS
> eK+l74G7xhxbqwKvIo8MgcLjwNYJG5hPJWoP6T9b9rBnE4W+x8J9ojcVVMuCWz/4
> 0GOGvgyRXwobDcKsAcBomNhTruOC8pqNVn6e84oScOyNf8QRP6GDjyj/a2jd71I=
> =Z5oS
> -----END PGP SIGNATURE-----
>
>


-- 
Takayoshi Kochi
Received on Friday, 2 October 2015 09:00:32 UTC

This archive was generated by hypermail 2.4.0 : Friday, 17 January 2020 18:14:58 UTC