Re: [whatwg/fetch] Add support for compression dictionary transport (PR #1854)

@fred-wang commented on this pull request.



> +given a <a for=/>fetch params</a> <var>fetchParams</var>, an optional boolean
+<var>includeCredentials</var> (default false), and an optional boolean <var>forceNewConnection</var>
+(default false):
+
+<ol>
+ <li><p>Let <var>request</var> be <var>fetchParams</var>'s <a for="fetch params">request</a>.
+
+ <li>
+  <p>Let <var>fallback</var> be the following steps:
+
+  <ol>
+   <li><p>Return the result of running <a>HTTP-network fetch</a> given <var>fetchParams</var>,
+   <var>includeCredentials</var>, and <var>forceNewConnection</var>.
+  </ol>
+
+ <li><p>If <var>request</var>'s <a for=request>mode</a> is "<code>no-cors</code>", then return the

compressed-large-resources-001 gives an example of compressed resources using img/script/link tags (as opposed to other tests that rely on the fetch API) and when we tried to implement this condition in WebKit, the test was failing unless we use an explicit crossorigin attribute to avoid triggering a no-cors request.

This indeed does not seem aligned with what Chromium is doing here:
https://source.chromium.org/chromium/chromium/src/+/main:services/network/cors/cors_url_loader.cc;l=366

I understand you mean to still allow fetching compression dictionaries for same origin requests too?


-- 
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/fetch/pull/1854#pullrequestreview-5101667932
You are receiving this because you are subscribed to this thread.

Message ID: <whatwg/fetch/pull/1854/review/5101667932@github.com>