Re: [whatwg/dom] Enqueue lifecycle callbacks before insertion/removing/moving steps (PR #1520)

@annevk commented on this pull request.

@rniwa as far as I can tell this indeed just changes order, not amount.

>       <var>inclusiveDescendant</var>'s <a for=ShadowRoot>custom element registry</a> is non-null, and
      <var>inclusiveDescendant</var>'s <a for=ShadowRoot>custom element registry</a>'s
      <a for=CustomElementRegistry>is scoped</a> is true, then <a for=set>append</a>
      <var>inclusiveDescendant</var>'s <a for=Node>node document</a> to
      <var>inclusiveDescendant</var>'s <a for=ShadowRoot>custom element registry</a>'s
      <a for=CustomElementRegistry>scoped document set</a>.
+
+     <li>
+      <p>Run the <a>insertion steps</a> with <var>inclusiveDescendant</var>.
+
+      <p class=note>The <code>connectedCallback</code> reaction, or the upgrade reaction, for
+      <var>inclusiveDescendant</var> is enqueued before the <a>insertion steps</a> run, so that any
+      reactions the <a>insertion steps</a> enqueue for <var>inclusiveDescendant</var> come after
+      it.

I don't think we want to add this note.

> @@ -3368,16 +3371,23 @@ optional boolean <dfn for=remove><var>suppressObservers</var></dfn> (default fal
   <p class=note>It is intentional for now that <a for=Element>custom</a> <a for=/>elements</a> do
   not get <var>parent</var> passed. This might change in the future if there is a need.
 
+ <li>
+  <p>Run the <a>removing steps</a> with <var>node</var>, true, and <var>parent</var>.
+
+  <p class=note>The <code>disconnectedCallback</code> reaction for <var>node</var> is enqueued
+  before the <a>removing steps</a> run, so that any reactions the <a>removing steps</a> enqueue
+  for <var>node</var> come after it. The same applies to its descendants below.

Ditto.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/dom/pull/1520#pullrequestreview-5780705560
You are receiving this because you are subscribed to this thread.

Message ID: <whatwg/dom/pull/1520/review/5780705560@github.com>