Re: [whatwg/fetch] Add support for compression dictionary transport (PR #1854)

@pmeenan commented on this pull request.



> +   "<code>dictionary</code>", and <var>response</var>'s <a for=response>header list</a>.
+
+   <li><p>If <var>dictionaryValue</var> is null or <var>dictionaryValue</var>["<code>match</code>"]
+   does not <a for=map>exist</a>, then return <var>response</var>.
+
+   <li><p>Let <var>compressionDictionaryCache</var> be the result of
+   <a>determining the compression-dictionary cache partition</a> given <var>request</var>.
+
+   <li><p>If <var>compressionDictionaryCache</var> is null, then return <var>response</var>.
+
+   <li><p>Let <var>pattern</var> be the result of
+   <a for=/>creating a URL pattern</a> given the bare item of <var>dictionaryValue</var>["<code>match</code>"],
+   the <a lt="URL serializer">serialization</a> of <var>request</var>'s <a for=request>current URL</a>,
+   and an empty map.
+
+   <li><p>If <var>pattern</var> is failure or <var>pattern</var> <a for=/>has regexp groups</a>,

I just landed a (hopefully comprehensive) set of WPT tests to cover all of the edge cases I could think of: https://github.com/web-platform-tests/wpt/pull/60164

* Invalid and out-of-scope `match` properties (syntax failures and  cross-origin patterns).
* Invalid/unsupported dictionary `type` tokens.
* Comprehensive `match-dest` parsing (unknown destinations,  matching/non-matching destinations, and explicit wildcards).
* Dictionary `id` maximum length validation (exactly 1024 characters vs  exceeding 1025 characters).
* Robustness against unknown additional dictionary parameters.
* Rejection of entirely malformed structured headers  (`Use-As-Dictionary: ?0`) and non-cacheable responses (`max-age=0`).
* Opaque response tainting resulting from cross-origin redirects under  `no-cors` mode correctly ignoring registration.
* Evaluation of `Available-Dictionary` on matching redirect targets across  redirect chains.
* Precedence evaluation when matching overlapping pattern scopes.
* Decoding failures resulting from dictionary hash mismatches throwing  clean network errors for both `dcb` and `dcz`.


-- 
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/fetch/pull/1854#discussion_r3305508652
You are receiving this because you are subscribed to this thread.

Message ID: <whatwg/fetch/pull/1854/review/4365848751@github.com>