Re: [whatwg/fetch] Add a textStream() method to the Body mixin (PR #1862)

@annevk commented on this pull request.



> @@ -8300,6 +8301,9 @@ due course.
 
  <dt><code><var>requestOrResponse</var> . <a method for=Body>text</a>()</code>
  <dd><p>Returns a promise fulfilled with <var>requestOrResponse</var>'s body as string.
+
+ <dt><code><var>requestOrResponse</var> . <a method for=Body>textStream</a>()</code> <dd><p>Returns

Is this another specfmt bug?

> @@ -8473,6 +8477,41 @@ of running <a for=Body>consume body</a> with <a>this</a> and <a>parse JSON from
 of running <a for=Body>consume body</a> with <a>this</a> and <a>UTF-8 decode</a>.
 </div>
 
+<div algorithm>
+<p>The <dfn method for=Body><code>textStream()</code></dfn> method steps are:</p>
+
+<ol>
+ <li><p>If <span>this</span> is <a for=Body>unusable</a>, then throw a {{TypeError}}.
+
+ <li>
+  <p>If <span>this</span>'s <a for=Body>body</a> is null, then:

```suggestion
  <p>If <span>this</span>'s <a for=Body>body</a> is null:
```

> @@ -8473,6 +8477,41 @@ of running <a for=Body>consume body</a> with <a>this</a> and <a>parse JSON from
 of running <a for=Body>consume body</a> with <a>this</a> and <a>UTF-8 decode</a>.
 </div>
 
+<div algorithm>
+<p>The <dfn method for=Body><code>textStream()</code></dfn> method steps are:</p>
+
+<ol>
+ <li><p>If <span>this</span> is <a for=Body>unusable</a>, then throw a {{TypeError}}.
+
+ <li>
+  <p>If <span>this</span>'s <a for=Body>body</a> is null, then:
+
+  <ol>
+   <li><p>Let <var>emptyStream</var> be a new {{ReadableStream}} in <a>this</a>'s <a>relevant
+   realm</a>,

No wrapping inside phrasing elements. And there's also a comma that should be period here...

> +
+  <ol>
+   <li><p>Let <var>emptyStream</var> be a new {{ReadableStream}} in <a>this</a>'s <a>relevant
+   realm</a>,
+
+   <li><p><a for="ReadableStream">Set up</a> <var>emptyStream</var>.
+
+   <li><p><a for="ReadableStream">Close</a> <var>emptyStream</var>.
+
+   <li><p>Return <var>emptyStream</var>.
+  </ol>
+
+ <li><p>Let <var>stream</var> be <a>this</a>'s <a for=Body>body</a>'s <a for=body>stream</a>.
+
+ <li><p>Let <var>decoder</var> be a new {{TextDecoderStream}} object in <a>this</a>'s <a>relevant
+ realm</a>.

No wrapping inside phrasing elements.

> +
+   <li><p><a for="ReadableStream">Set up</a> <var>emptyStream</var>.
+
+   <li><p><a for="ReadableStream">Close</a> <var>emptyStream</var>.
+
+   <li><p>Return <var>emptyStream</var>.
+  </ol>
+
+ <li><p>Let <var>stream</var> be <a>this</a>'s <a for=Body>body</a>'s <a for=body>stream</a>.
+
+ <li><p>Let <var>decoder</var> be a new {{TextDecoderStream}} object in <a>this</a>'s <a>relevant
+ realm</a>.
+
+ <li>
+  <p><a data-lt="set up a text decoder stream">Set up</a> <var>decoder</var> with <a
+  for=/>UTF-8</a>. <p class=note>This is done regardless of the presence or the value of a

specfmt?

-- 
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/fetch/pull/1862#pullrequestreview-4336280005
You are receiving this because you are subscribed to this thread.

Message ID: <whatwg/fetch/pull/1862/review/4336280005@github.com>