Re: [whatwg/fullscreen] Add keyboard locking option (PR #232)

@foolip commented on this pull request.

Style nits and just one question about the naming.

> @@ -177,7 +178,28 @@ steps:
 <p class=note>These steps integrate with the <a for=/>event loop</a> defined in HTML. [[!HTML]]
 </div>
 
+<hr>
+
+<p>All <a>elements</a> have an associated <dfn>keyboard lock flag</dfn>. Unless stated otherwise it
+is unset.
+
+<p>A [=document=] has <dfn>keyboard lock</dfn> active when its [=fullscreen element=] is not null
+and the [=fullscreen element=]'s [=keyboard lock flag=] is true, and inactive otherwise.

```suggestion
and the [=fullscreen element=]'s [=keyboard lock flag=] is set, and inactive otherwise.
```

> +    <li><p>If the [=keyboard lock flag=] for <var>document</var>'s <a>fullscreen element</a> is
+    false, then return.

```suggestion
    <li><p>If <var>document</var>'s <a>fullscreen element</a>'s [=keyboard lock flag=] is unset,
    then return.
```

> +    <li><p>Set the [=keyboard lock flag=] for <var>document</var>'s <a>fullscreen element</a> to
+    false.

```suggestion
    <li><p>Unset <var>document</var>'s <a>fullscreen element</a>'s [=keyboard lock flag=].
```

> +  <p>To <dfn>run the release the keyboard lock steps</dfn> for a <a>document</a>
+  <var>document</var>, run these steps:

I realize this is modeled after "run the fullscreen steps", but that one's hard to name as an algorithm without the extra "run the" and "steps". In this case:


```suggestion
  <p>To <dfn>release the keyboard lock</dfn> for a <a>document</a> <var>document</var>, run these
  steps:
```

> @@ -506,6 +553,8 @@ could be an open <{dialog}> element.
 
  <li><p>Return <var>promise</var>, and run the remaining steps <a>in parallel</a>.
 
+ <li><p>[=Run the release the keyboard lock steps=] with <var>doc</var>.

```suggestion
 <li><p>[=Release the keyboard lock=] for <var>doc</var>.
```

> @@ -188,7 +210,13 @@ enum FullscreenNavigationUI {
   "hide"
 };
 
+enum FullscreenKeyboardLock {
+  "browser",

The naming of this enum seems a bit unusual, although not unprecedented:
- https://w3c.github.io/mediacapture-screen-share/#displaycapturesurfacetype (used instead of "tab" I think, an in contrast to "window")
- https://w3c.github.io/secure-payment-confirmation/#sctn-browser-bound-key-store

Has this already shipped? If so it's too late to change, but if not would "auto" be acceptable?

-- 
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/fullscreen/pull/232#pullrequestreview-4220288619
You are receiving this because you are subscribed to this thread.

Message ID: <whatwg/fullscreen/pull/232/review/4220288619@github.com>