- From: Noam Rosenthal <notifications@github.com>
- Date: Tue, 10 Mar 2026 02:26:40 -0700
- To: whatwg/dom <dom@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
Received on Tuesday, 10 March 2026 09:26:44 UTC
@noamr commented on this pull request.
> +<div algorithm>
+<p>To <dfn>update attributes from data</dfn> for a {{ProcessingInstruction}} <a for=/>node</a>
+<var>pi</var>:
+
+<ol>
+ <li><p><a for=map>Clear</a> <var>pi</var>'s <a for=ProcessingInstruction>attribute map</a>.
+
+ <li><p>Let <var>context</var> be the result of <a>creating an element</a> given
+ <var>pi</var>'s <a>node document</a>, "<code>html</code>", and the <a>HTML namespace</a>.
+
+ <li><p>Let <var>markup</var> be the concatentation of "<code><attrs </code>",
+ <var>pi</var>'s <a for=CharacterData>data</a>, and
+ "<code>></attrs></code>".
+
+ <li><p>Let <var>fragment</var> be the result of invoking the
+ <a>fragment parsing algorithm steps</a> with <var>context</var> and <var>markup</var>.
> I'm not sure which constructor has such global-depending side effects on one of its arguments?
One of the arguments? None. But perhaps we don't need a constructor or it doesn't have to have a data argument if the constructor is the main concern?
--
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/dom/pull/1454#discussion_r2910432973
You are receiving this because you are subscribed to this thread.
Message ID: <whatwg/dom/pull/1454/review/3920962805@github.com>
Received on Tuesday, 10 March 2026 09:26:44 UTC