Re: [whatwg/dom] Define processing instruction attributes (PR #1454)

@foolip commented on this pull request.



> + <li><p>Let <var>fragment</var> be the result of invoking the
+ <a>fragment parsing algorithm steps</a> with <var>context</var> and <var>markup</var>. If this
+ throws an exception, then return.
+
+ <li>
+  <p>If <var>fragment</var>'s <a>first child</a> is an <a for=/>element</a>:
+
+  <ol>
+   <li><p>Let <var>element</var> be the <a>first child</a> of <var>fragment</var>.
+
+   <li><p>Assert: <var>element</var> is an <a for=/>element</a> with <a for=Element>local name</a>
+   "<code>attrs</code>".
+
+   <li><p><a for=list>For each</a> <var>attribute</var> of <var>element</var>'s
+   <a for=Element>attribute list</a>, set <var>pi</var>'s
+   <a for=ProcessingInstruction>attribute map</a>[<var>attribute</var>'s <a for=Attr>local name</a>]

Using the local name here means ignoring the namespace, but with input like `<?target attr="value" xmlns:bla="..." bla:attr="blavalue"?>` in XML, the second attribute would clobber the first and the result would be a single attribute with value "blavalue". That seems worse than for example erroring if the namespace is not null.

This seems like something @zcorpan might have opinions on :)

-- 
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/dom/pull/1454#pullrequestreview-3918637690
You are receiving this because you are subscribed to this thread.

Message ID: <whatwg/dom/pull/1454/review/3918637690@github.com>