- From: Philip Jägenstedt <notifications@github.com>
- Date: Mon, 09 Mar 2026 07:14:34 -0700
- To: whatwg/dom <dom@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
- Message-ID: <whatwg/dom/pull/1454/review/3915713010@github.com>
@foolip commented on this pull request.
> +<div algorithm>
+<p>To <dfn>update attributes from data</dfn> for a {{ProcessingInstruction}} <a for=/>node</a>
+<var>pi</var>:
+
+<ol>
+ <li><p><a for=map>Clear</a> <var>pi</var>'s <a for=ProcessingInstruction>attribute map</a>.
+
+ <li><p>Let <var>context</var> be the result of <a>creating an element</a> given
+ <var>pi</var>'s <a>node document</a>, "<code>html</code>", and the <a>HTML namespace</a>.
+
+ <li><p>Let <var>markup</var> be the concatentation of "<code><attrs </code>",
+ <var>pi</var>'s <a for=CharacterData>data</a>, and
+ "<code>></attrs></code>".
+
+ <li><p>Let <var>fragment</var> be the result of invoking the
+ <a>fragment parsing algorithm steps</a> with <var>context</var> and <var>markup</var>.
XML errors would result in a "SyntaxError" exception per https://html.spec.whatwg.org/#xml-fragment-parsing-algorithm, and thus leave the PI without any attributes.
If you don't want this to depend on the document, we could use the HTML parser unconditionally, but that would mean that `<?xml-stylesheet href=style.css?>` starts working in XML, and might force non-browsers that process XML documents with such PIs to parse those attribute as HTML.
I think using a different parser depending on the document is the most consistent with existing APIs like `innerHTML`, and avoids affecting existing content as much as possible.
--
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/dom/pull/1454#discussion_r2905699874
You are receiving this because you are subscribed to this thread.
Message ID: <whatwg/dom/pull/1454/review/3915713010@github.com>
Received on Monday, 9 March 2026 14:14:38 UTC