- From: Marcos Cáceres <notifications@github.com>
- Date: Sun, 01 Mar 2026 21:16:29 -0800
- To: whatwg/fullscreen <fullscreen@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
Received on Monday, 2 March 2026 05:16:33 UTC
@marcoscaceres commented on this pull request.
> dictionary FullscreenOptions {
+ FullscreenKeyboardLock keyboardLock = "none";
Maybe... what I like about "none" is that it's explicit about "no lock is applied"... vs `undefined`, which, yes, could mean "no lock is applied", but also means "undefined behavior (and potentially the browser is applying UA specific behavior)".
My question is, which one do we want? These are subtle, but important differences IMO,
--
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/fullscreen/pull/232#discussion_r2870550911
You are receiving this because you are subscribed to this thread.
Message ID: <whatwg/fullscreen/pull/232/review/3874112836@github.com>
Received on Monday, 2 March 2026 05:16:33 UTC