- From: Domenic Denicola <notifications@github.com>
- Date: Tue, 30 Jun 2026 00:15:05 -0700
- To: whatwg/url <url@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
Received on Tuesday, 30 June 2026 07:15:09 UTC
@domenic approved this pull request. LGTM. Prototyped in https://github.com/jsdom/whatwg-url/pull/326. After this PR, the gaps Claude identified in https://github.com/whatwg/url/pull/905#issuecomment-4833262285 remain, and have test cases in the above-linked PR. > @@ -1072,6 +1069,9 @@ false), and then runs these steps. They return failure or a <a for=/>host</a>. <li><p>Assert: <var>input</var> is not the empty string. + <li><p>If <var>input</var> contains a <a>percent-encoded byte</a>, Nit: it would be nice if the definition of "percent encoded byte" mentioned that it was a type of three-character string, and not a type of byte. -- Reply to this email directly or view it on GitHub: https://github.com/whatwg/url/pull/905#pullrequestreview-4597990473 You are receiving this because you are subscribed to this thread. Message ID: <whatwg/url/pull/905/review/4597990473@github.com>
Received on Tuesday, 30 June 2026 07:15:09 UTC