Re: [w3c/manifest] Add support for defining a theme color for both light & dark modes (prefers color scheme) (#975)

christianliebel left a comment (w3c/manifest#975)

> Regarding 'icons_localized' - it is currently being implemented but not shipped yet. If we can come to agreement here within a month or so I think it's reasonable to change the impl. But we should really try to not delay indefinitely. Adding icon properties as mentioned seems reasonable from a quick squint.

@dmurph I'm not sure if we should change the i18n system again. Getting the whole `*_localized` system through the door was an enormous effort back then. If we make any changes, we might have to iterate with i18n again, and it reverts previous resolutions (for example, https://github.com/w3c/manifest/pull/1101#issuecomment-1793071010). On the other hand, now may be the last possible chance.

@carlosjeurissen What would the exact proposal be?

```json
{ 
  "lang": "de",
  "name": "Coole App",
  "name_localized": { "en": "Cool App" },
  "icons": [
    { "src": "a.png" },
    { "src": "b.png", "lang": "en" },
    { "src": "c.png", "color_scheme": "dark" },
    { "src": "d.png", "lang": "en", "color_scheme": "dark" },
  ]
}
```

instead of 

```json
{ 
  "lang": "de",
  "name": "Coole App",
  "name_localized": { "en": "Cool App" },
  "icons": [{ "src": "a.png" }],
  "icons_localized": { "en": [{ "src": "b.png" }] },
  "color_scheme_dark": {
    "icons": [{ "src": "c.png" }],
    "icons_localized": { "en": [{ "src": "d.png" }] }
  }
}
```

? Arrays for `lang` and `color_scheme`?

@dmurph @aarongustafson I would also just go with the root-level member now. `overrides` never became a thing. I suppose we have to accept the limitations of the JSON format, and understand that any solution we choose will have its disadvantages. However, taking no action at all doesn't seem to make sense either.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/w3c/manifest/issues/975#issuecomment-3784690375
You are receiving this because you are subscribed to this thread.

Message ID: <w3c/manifest/issues/975/3784690375@github.com>