Re: [w3c/manifest] Add support for defining a theme color for both light & dark modes (prefers color scheme) (#975)

carlosjeurissen left a comment (w3c/manifest#975)

`dark_colors` seems to cover the majority of use cases. This sounds good! We can always introduce a future global `color_variants` property which overrides both the global and `dark_colors` members if we conclude this level of sophistication would be needed to cover for more contrast, high contrast, transparent, or other kind of conditions or combinations of them.

As for `icons`, having two lists of icons (`icons` and  `dark_icons`) and all the potential localised lists (`icons_localized and `dark_icons_localized`), could be potentially problematic. As it is unclear if developers are supposed to repeat all the variations like monochrome icons inside the `dark_icons`. What if an agent is seeking a 128px icon in dark mode, which exists in `icons` but not in `dark_icons`. Would it use the 64px icon from `dark_icons` or use the 128px icon from `icons`? For developers, it would not be clear to tell agents what the developers intended preferred order of fallbacks should be.

Depending on if `icons_localized` is already being implemented (@christianliebel), I see value of going for one flat list in `icons` similar to the `icon_variants` logic of webExtensions. In which you would allow language as property. IE, allow to specify a specific icon should be used for `lang: ["ru", "be", "uk"]`. This would also greatly reduce the amount of icons which are needed to be declared in the manifest with these four set of objects.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/w3c/manifest/issues/975#issuecomment-3754425660
You are receiving this because you are subscribed to this thread.

Message ID: <w3c/manifest/issues/975/3754425660@github.com>