Re: [whatwg/fetch] Add WebDriver BiDi network logging with stable request IDs (PR #1860)

@zcorpan commented on this pull request.



> @@ -2374,7 +2370,9 @@ is to return the result of <a>serializing a request origin</a> with <var>request
 
 <ol>
  <li><p>Let <var>newRequest</var> be a copy of <var>request</var>, except for its
- <a for=request>body</a>.
+ <a for=request>body</a> and <a for=request>WebDriver id</a>.
+
+ <li><p>Set <var>newRequest</var>'s <a for=request>WebDriver id</a> to a new unique string.

Should there be more details about this string? Maybe https://w3c.github.io/webcrypto/#dfn-generate-a-random-uuid ? What is implemented?

> @@ -5203,6 +5182,11 @@ steps:
  <a>network error</a>; otherwise <var>response</var>'s
  <a for="filtered response">internal response</a>.
 
+ <li><p>If <var>response</var> is a <a>network error</a>, run

```suggestion
 <li><p>If <var>response</var> is a <a>network error</a>, then run
```

> @@ -5203,6 +5182,11 @@ steps:
  <a>network error</a>; otherwise <var>response</var>'s
  <a for="filtered response">internal response</a>.
 
+ <li><p>If <var>response</var> is a <a>network error</a>, run
+ the <a>WebDriver BiDi fetch error</a> steps with <var>request</var>. Otherwise

```suggestion
 the <a>WebDriver BiDi fetch error</a> steps with <var>request</var>. Otherwise,
```

> @@ -6295,6 +6253,8 @@ run these steps:
  <li><p><a>If aborted</a>, then return the <a for=/>appropriate network error</a> for
  <var>fetchParams</var>.
 
+ <li><p>If <var>response</var> is not null, run the <a>WebDriver BiDi response

```suggestion
 <li><p>If <var>response</var> is not null, then run the <a>WebDriver BiDi response
```

> @@ -6790,8 +6835,9 @@ populates the <a>CORS-preflight cache</a> to minimize the number of these
   <a for=request>origin</a> is <var>request</var>'s <a for=request>origin</a>,
   <a for=request>referrer</a> is <var>request</var>'s <a for=request>referrer</a>,
   <a for=request>referrer policy</a> is <var>request</var>'s <a for=request>referrer policy</a>,
-  <a for=request>mode</a> is "<code>cors</code>", and
-  <a for=request>response tainting</a> is "<code>cors</code>".
+  <a for=request>mode</a> is "<code>cors</code>",
+  <a for=request>response tainting</a> is "<code>cors</code>", and
+  <a for=request>WebDriver id</a> is <var>request</var>'s <a for=request>WebDriver id</a>.

This looks right to me.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/fetch/pull/1860#pullrequestreview-3812460769
You are receiving this because you are subscribed to this thread.

Message ID: <whatwg/fetch/pull/1860/review/3812460769@github.com>