Re: [whatwg/dom] Pass better parent/root information to (re)moving steps. (PR #1450)

@annevk commented on this pull request.



> @@ -3270,9 +3273,9 @@ from a <a for=/>node</a> <var>parent</var>:
 <div algorithm>
 <p><a lt="Other applicable specifications">Specifications</a> may define
 <dfn export id=concept-node-remove-ext>removing steps</dfn> for all or some <a for=/>nodes</a>. The
-algorithm is passed a <a for=/>node</a> <var ignore>removedNode</var> and a
-<a for=/>node</a>-or-null <var ignore>oldParent</var>, as indicated in the <a for=/>remove</a>
-algorithm below.
+algorithm is passed a <a for=/>node</a> <var ignore>removedNode</var>, a <a for=/>node</a>
+<var ignore>oldAncestor</var>, and a boolean <var ignore>isSubtreeRoot</var> as indicated in the
+<a for=/>remove</a> algorithm below.

Let's change the order here as well for consistency. We'll have to audit & update callers anyway.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/dom/pull/1450#pullrequestreview-3779786316
You are receiving this because you are subscribed to this thread.

Message ID: <whatwg/dom/pull/1450/review/3779786316@github.com>