Re: [w3c/manifest] Add `color_scheme_dark` member and themeable members (colors only) (PR #1207)

@Copilot commented on this pull request.

## Pull request overview

Adds a manifest-level mechanism to specify dark-mode overrides for color-related members, addressing the need to provide different theme/background colors for light vs. dark color schemes (Issue #975).

**Changes:**
- Marks `theme_color` and `background_color` as “themeable members”.
- Introduces a new `color_scheme_dark` manifest member (ordered map) to hold dark-theme overrides.
- Adds a processing algorithm for `color_scheme_dark` and hooks it into the manifest processing steps.





---

💡 <a href="/w3c/manifest/new/main/.github/instructions?filename=*.instructions.md" class="Link--inTextBlock" target="_blank" rel="noopener noreferrer">Add Copilot custom instructions</a> for smarter, more guided reviews. <a href="https://docs.github.com/en/copilot/customizing-copilot/adding-repository-custom-instructions-for-github-copilot" class="Link--inTextBlock" target="_blank" rel="noopener noreferrer">Learn how to get started</a>.

> +          A <dfn>themeable member</dfn> is a [=manifest=] member that can be
+          themed.

The prose says `color_scheme_dark` keys are the names of "themeable members", but the processing algorithm only recognizes/processes "theme_color" and "background_color". This creates an inconsistency about what keys are actually allowed/handled (and implies additional keys might work when they’ll be ignored). Consider explicitly enumerating the supported keys (currently the two color members) and/or defining "themeable members" as a fixed set and iterating over that set in the algorithm.
```suggestion
          The set of <dfn>themeable members</dfn> is fixed to the following
          [=manifest=] members: <code>background_color</code> and
          <code>theme_color</code>.
```

> @@ -1497,6 +1503,78 @@ <h3>
           </ol>
         </section>
       </section>
+      <section>
+        <h3>
+          `color_scheme_dark` member
+        </h3>
+        <p>
+          The [=manifest's=] <code><dfn data-export="" data-dfn-for=
+          "manifest">color_scheme_dark</dfn></code> member is an [=ordered
+          map=] whose keys are the names of [=themeable members=], while the
+          values are their corresponding theme overrides.

"theme overrides" is introduced here but not defined elsewhere in the document. Consider either defining what a "theme override" is (including its value type) or rephrasing to state that the values are the same types as the corresponding members (e.g., color strings) and are processed with the existing color-member processing algorithm.
```suggestion
          values are their corresponding <dfn>theme overrides</dfn>. A theme
          override is a value of the same type as its corresponding
          [=themeable member=] (for example, a color string for a color
          member) and is processed using that member's existing processing
          algorithm.
```

> +        <h3>
+          `color_scheme_dark` member
+        </h3>
+        <p>
+          The [=manifest's=] <code><dfn data-export="" data-dfn-for=
+          "manifest">color_scheme_dark</dfn></code> member is an [=ordered
+          map=] whose keys are the names of [=themeable members=], while the
+          values are their corresponding theme overrides.
+        </p>
+        <p>
+          A <dfn>themeable member</dfn> is a [=manifest=] member that can be
+          themed.
+        </p>
+        <aside class="example" title="Example manifest with a dark theme">
+          <pre class="json">
+            { 

The JSON example contains trailing whitespace after the opening `{` on the first line of the snippet. Please remove the trailing space to keep the spec source clean (and avoid whitespace-only diffs if tooling normalizes it).
```suggestion
            {
```

-- 
Reply to this email directly or view it on GitHub:
https://github.com/w3c/manifest/pull/1207#pullrequestreview-3777954992
You are receiving this because you are subscribed to this thread.

Message ID: <w3c/manifest/pull/1207/review/3777954992@github.com>