Re: [whatwg/dom] Pass better parent/root information to (re)moving steps. (PR #1450)

@annevk commented on this pull request.

Thank you for fixing this. I think we should rename _oldParent_ then to something that reflects it can be an ancestor as well. _oldAncestor_ might be good enough? Or maybe _oldSubtreeRoot_ if we wanted a little more precision. WDYT?

> @@ -3108,9 +3108,10 @@ to do these things asynchronously, however.
 
   <ol>
    <li>
-    <p>If <var>inclusiveDescendant</var> is <var>node</var>, then run the <a>moving steps</a> with
-    <var>inclusiveDescendant</var> and <var>oldParent</var>. Otherwise, run the <a>moving steps</a>
-    with <var>inclusiveDescendant</var> and null.
+    <p>Let <var>isSubtreeRoot</var> be whether <var>inclusiveDescendant</var> is <var>node</var>.

Do we need this in standards? It seems you can determine this by checking this's parent as well?

-- 
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/dom/pull/1450#pullrequestreview-3774757006
You are receiving this because you are subscribed to this thread.

Message ID: <whatwg/dom/pull/1450/review/3774757006@github.com>