Re: [w3c/manifest] Add support for defining a theme color for both light & dark modes (prefers color scheme) (#975)

dmurph left a comment (w3c/manifest#975)

Regarding screenshots:
- Yes, it's definitely different with wanting multiple and the order mattering more. I believe for screenshots the parts of the 'algorithm' I had above would mostly be executing the pre-filter part, to remove all of the wrong platform stuff, and then just return them all after that. So - same 'algorithm' but the user agent would never specify a constraint list kinda (except for lang) - as screenshots don't have purpose or color scheme.

Regarding constraints:
- I agree that there is an initial filter step, then a constraint search step. Definitely the algorithm could return a list if we want more than one, instead of just one. That could be a different mode. That helps for screenshots.
- For 'constraints not known'.... I 'think' that is OK? I guess for supporting backwards compatibility, if a new constraint is added... yeah you would need to have entries without that new constraint anyways.... so that seems fine....
- And yes - to me it seems like this can be a statically defined list, and IMO in the real world:
  - if there is a problem with this precidence (e.g. the dark-maskable-french example above where it used the non-french icon due to no french icon specified that was dark), the developer can simply just add the french-maskable-dark icon and fix it.


I am interested in the opinion of @christianliebel for incorporating the 'lang' into the icons vs separate dicts per lang, like we currently have. e.g. is that better dev ergonomics, especially if we change it so that we can specify multiple lang keys in the dict key (`"en": {}, "en-UK en-CA": {}, ...`) to help with duplication.


-- 
Reply to this email directly or view it on GitHub:
https://github.com/w3c/manifest/issues/975#issuecomment-3861957403
You are receiving this because you are subscribed to this thread.

Message ID: <w3c/manifest/issues/975/3861957403@github.com>