Re: [w3c/manifest] Add support for defining a theme color for both light & dark modes (prefers color scheme) (#975)

dmurph left a comment (w3c/manifest#975)

Discussion at US/EU manifest spec meeting [here](https://docs.google.com/document/d/1DdU_3NhxOsEnzRUjxUrGqxaGgcom3s9jF5nYhtkG26E/edit?tab=t.0#bookmark=id.y5z5swmm78i0).

@christianliebel raised a bunch of good points about src and backwards compatibility - our conclusions:

* Because we skip icon parsing if ‘src’ is not present (confirmed chrome, webkit gecko), we can use that to ensure we don’t break compatibility  
* Options that seemed best right now  
  1. Fully move to the webextensions format, % needing them / us to specify how the ‘any’ size is chosen (first vs fallback). We also need non-square sizes for screenshots.  
     * This is a BIG spec change. We would formalize the new format, and have the legacy format ‘parse’ into the new format  
     * Code change definitely, but likely not huge. Not a new OS integration  
     * Definitely devrel effort  
  2. Support the webextensions format but ‘parse’ it into the old format. This, for devs, is the same as the first option, but for us is less work, as the spec change is smaller, and the code changes are smaller  
  3. Otherwise, doing only color\_scheme addition has backwards compatibility risk UNLESS we can confirm that Gecko & WebKit will always choose the ‘last’ appropriate icon from the list \- this is what Chrome does. So devs who add color scheme icons would need to make sure that it is ‘first’ in the list, and they have equivalent icon later in the list for the legacy impls to choose  
  4. I18n might be better if the languages are separate, so we could do the above two only for color\_scheme, and keep the icons and icons\_localized situation. This is easier for translators, but might be harder for devs to know exactly what icon is chosen.  
  5. Other options seem kinda sad, like fully denormalized  
     * Icons  
     * Icons\_dark\_color  
     * Icons\_dark\_color\_localized  
     * Icons\_localized  
     * Etc 😢

Interested in the thoughts of others.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/w3c/manifest/issues/975#issuecomment-3855395861
You are receiving this because you are subscribed to this thread.

Message ID: <w3c/manifest/issues/975/3855395861@github.com>