Re: [whatwg/dom] Copy a document's base URL when cloning (PR #1492)

@domfarolino commented on this pull request.

Please link to https://github.com/whatwg/html/pull/12674 from the OP.

> @@ -5638,6 +5650,16 @@ known as <dfn export id=concept-document lt="document">documents</dfn>.
 Whether a <a for=/>document</a> is an <a>HTML document</a> or an <a>XML document</a> affects the
 behavior of certain APIs.
 
+<p>Each <a for=/>document</a> has an associated <dfn export>get the base URL</dfn> algorithm, which
+returns a <a for=/>URL</a> or null. Unless specified otherwise it returns null.

Should we make the overridability of these steps more explicit, like https://dom.spec.whatwg.org/#concept-node-insert-ext does?

> @@ -5638,6 +5650,16 @@ known as <dfn export id=concept-document lt="document">documents</dfn>.
 Whether a <a for=/>document</a> is an <a>HTML document</a> or an <a>XML document</a> affects the
 behavior of certain APIs.
 
+<p>Each <a for=/>document</a> has an associated <dfn export>get the base URL</dfn> algorithm, which
+returns a <a for=/>URL</a> or null. Unless specified otherwise it returns null.
+
+<p>Each <a for=/>document</a> has a <dfn export>base URL override</dfn> (a <a for=/>URL</a> or
+null), initially null.
+
+<p class=note>HTML overrides the <a>get the base URL</a> algorithm to account for the
+<code>base</code> element, and sets the <a>base URL override</a> for "<code>about:</code>"-schemed
+<a for=/>documents</a>. [[!HTML]]

Maybe let's also mention that this is also set (by this spec of course, not HTML) during document cloning. I was initially confused why we didn't retain its original descriptive name, until I realized that's because this PR assigns it in new, non-`about:` cases.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/dom/pull/1492#pullrequestreview-5036235422
You are receiving this because you are subscribed to this thread.

Message ID: <whatwg/dom/pull/1492/review/5036235422@github.com>