- From: Anne van Kesteren <notifications@github.com>
- Date: Fri, 21 Aug 2026 07:09:41 -0700
- To: whatwg/webidl <webidl@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
- Message-ID: <whatwg/webidl/pull/1630@github.com>
The polarity was flipped in #1420, which turned `Assert: IsDetachedBuffer(jsArrayBuffer) is false.` into a conditional throw but kept `is false`.
That the intent is to throw when detached is confirmed by the note below the algorithm, which lists "is already detached" as a throwing condition. Step 5's `? DetachArrayBuffer` cannot produce that error, as detaching an already-detached buffer is a no-op.
Fixes #1619.
<!--
This comment and the below content is programmatically generated.
You may add a comma-separated list of anchors you'd like a
direct link to below (e.g. #idl-serializers, #idl-sequence):
Don't remove this comment or modify anything below this line.
If you don't want a preview generated for this pull request,
just replace the whole of this comment's content by "no preview"
and remove what's below.
-->
***
<a href="https://whatpr.org/webidl/1630.html" title="Last updated on Aug 21, 2026, 2:09 PM UTC (d2fe0d5)">Preview</a> | <a href="https://whatpr.org/webidl/1630/fad9b4c...d2fe0d5.html" title="Last updated on Aug 21, 2026, 2:09 PM UTC (d2fe0d5)">Diff</a>
You can view, comment on, or merge this pull request online at:
https://github.com/whatwg/webidl/pull/1630
-- Commit Summary --
* Fix inverted detached buffer check in ArrayBuffer transfer
-- File Changes --
M index.bs (2)
-- Patch Links --
https://github.com/whatwg/webidl/pull/1630.patch
https://github.com/whatwg/webidl/pull/1630.diff
--
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/webidl/pull/1630
You are receiving this because you are subscribed to this thread.
Message ID: <whatwg/webidl/pull/1630@github.com>
Received on Friday, 21 August 2026 14:09:45 UTC