- From: Mike West <notifications@github.com>
- Date: Wed, 29 Apr 2026 06:41:31 -0700
- To: whatwg/fetch <fetch@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
- Message-ID: <whatwg/fetch/pull/1924/review/4197470423@github.com>
@mikewest commented on this pull request. > + / [ *2( h16 ":" ) h16 ] "::" 2( h16 ":" ) h16 + / [ *3( h16 ":" ) h16 ] "::" h16 ":" h16 + / [ *4( h16 ":" ) h16 ] "::" h16 + / [ *5( h16 ":" ) h16 ] "::" +<dfn export>h16</dfn> = "0" / ( non-zero-hex 0*3hex ) +<dfn export>non-zero-hex</dfn> = %x31-39 / %x61-66 ; '1'-'9' or lowercase 'a'-'f' +<dfn export>hex</dfn> = %x30-39 / %x61-66 ; '0'-'9' or lowercase 'a'-'f + +<dfn export>lower-alpha</dfn> = %x61-7A +<dfn export>lower-alphanum</dfn> = <a>lower-alpha</a> / DIGIT +<dfn export>domain-label</dfn> = <a>lower-alphanum</a> / ( <a>lower-alphanum</a> *( <a>lower-alphanum</a> / "-" ) <a>lower-alphanum</a> ) +<dfn export>serialized-domain</dfn> = *( <a>domain-label</a> "." ) <a>domain-label</a> + +<dfn export>serialized-scheme</dfn> = <a>lower-alpha</a> *( <a>lower-alphanum</a> / "+" / "-" / "." ) +<dfn export>serialized-host</dfn> = <a>serialized-ipv4</a> / "[" <a>serialized-ipv6</a> "]" / <a>serialized-domain</a> +<dfn export>serialized-port</dfn> = 1*5DIGIT If you want to get much more granular, we'd probably want to do something similar to `dec-octet` to spell out all the valid numbers between 0 and 65535: ``` DIGIT ; 0-9 / %x31-39 1*3DIGIT ; 10-9999 / %x31-35 4DIGIT ; 10000-59999 / "6" %x30-34 3DIGIT ; 60000-64999 / "65" %x30-34 2DIGIT ; 65000-65499 / "655" %x30-32 DIGIT ; 65500-65529 / "6553" %x30-35 ; 65530-65535 ``` That seems like overkill to me (and, really, much of the complexity in this patch is arguably over the line of what grammar should be responsible for already). It's a kinda fun little puzzle to see what we can do with the grammar, but I'm not sure it's helpful. @annevk, WDYT? -- Reply to this email directly or view it on GitHub: https://github.com/whatwg/fetch/pull/1924#discussion_r3161434753 You are receiving this because you are subscribed to this thread. Message ID: <whatwg/fetch/pull/1924/review/4197470423@github.com>
Received on Wednesday, 29 April 2026 13:41:35 UTC