Re: [whatwg/fullscreen] Add keyboard locking option (PR #232)

zcorpan left a comment (whatwg/fullscreen#232)

> `document.fullscreen` is deprecated though.
> 
> https://fullscreen.spec.whatwg.org/#dom-document-fullscreen

Yes, because `fullscreenElement` exists, but I think a boolean seems more useful for keyboard lock.

> > Use the [fullscreenElement](https://fullscreen.spec.whatwg.org/#dom-document-fullscreenelement) attribute instead.
> 
> I wonder we can convert it to a dictionary that represents fullscreen options.

Why? `navigationUI` seems like it doesn't need to be exposed.

> re: keyboardLockEnabled, that effectively sounds like it will expose keyboard existence.

Good point, maybe the API should act like it's always available even if there's no keyboard. Then I guess we also don't want to reject in `requestFullscreen`.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/fullscreen/pull/232?email_source=notifications&email_token=ACLYVMI6DMF7E2MD6RVQ4334XDNXFA5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTIMRZG4ZTQNZYHE4KM4TFMFZW63VKON2WE43DOJUWEZLEUVSXMZLOOS2XA4S7MNXW23LFNZ2F633QMVXF6Y3MNFRWW#issuecomment-4297387898
You are receiving this because you are subscribed to this thread.

Message ID: <whatwg/fullscreen/pull/232/c4297387898@github.com>